linux-kernel - [PATCH] x86_dump_trace: avoiding endless " <IRQ> " is printed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 13 Aug 2012 09:05:23 +0000
From:	"Liu, Chuansheng" <chuansheng.liu@...el.com>
To:	"'linux-kernel@...r.kernel.org' (linux-kernel@...r.kernel.org)" 
	<linux-kernel@...r.kernel.org>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>
Subject: [PATCH] x86_dump_trace: avoiding endless " <IRQ> " is printed

From: liu chuansheng <chuansheng.liu@...el.com>
Subject: [PATCH] x86_dump_trace: avoiding endless " <IRQ> " is printed

Found the case that endless " <IRQ> " printing in dump_trace,
and no real meaningful stack traces are output, so there should
one rare case that possibly context->previous_esp = context or
other cases.

The endless " <IRQ> " is as below:
...
[   82.215244,0]  <IRQ>
[   82.215399,0]  <IRQ>
[   82.215554,0]  <IRQ>
[   82.215710,0]  <IRQ>
[   82.215865,0]  <IRQ>
[   82.216022,0]  <IRQ>
[   82.216178,0]  <IRQ>
[   82.216333,0]  <IRQ>
[   82.216488,0]  <IRQ>
[   82.216643,0]  <IRQ>
[   82.216798,0]  <IRQ>
[   82.216953,0]  <IRQ>
...

This patch aim is:
1/ Limiting the " <IRQ> " outputing, currently the max IRQ contexts
is 2(softirq+harirq combination);
2/ When the max IRQ contexts 2 is reached, print the context content
to confirm;

Signed-off-by: liu chuansheng <chuansheng.liu@...el.com>
---
 arch/x86/kernel/dumpstack_32.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/dumpstack_32.c b/arch/x86/kernel/dumpstack_32.c
index 1038a41..5387429 100644
--- a/arch/x86/kernel/dumpstack_32.c
+++ b/arch/x86/kernel/dumpstack_32.c
@@ -22,6 +22,7 @@ void dump_trace(struct task_struct *task, struct pt_regs *regs,
                const struct stacktrace_ops *ops, void *data)
 {
        int graph = 0;
+       int dump_irq = 0;
 
        if (!task)
                task = current;
@@ -47,8 +48,18 @@ void dump_trace(struct task_struct *task, struct pt_regs *regs,
                stack = (unsigned long *)context->previous_esp;
                if (!stack)
                        break;
+
+               if (unlikely(dump_irq > 2)) {
+                       printk(KERN_WARNING "break multi-IRQ print,"
+                               "context=%08lx, stack=%08lx\n",
+                               (unsigned long)context,
+                               (unsigned long)stack);
+                       break;
+               }
+
                if (ops->stack(data, "IRQ") < 0)
                        break;
+               dump_irq++;
                touch_nmi_watchdog();
        }
 }
-- 
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/