linux-kernel - Re: bisected regression: v3.6-rc1: resume from s2ram does not restore ata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120814114420.2e844ea1@sf>
Date:	Tue, 14 Aug 2012 11:44:20 +0300
From:	Sergei Trofimovich <slyich@...il.com>
To:	Aaron Lu <ziqian.lu@...el.com>
Cc:	Matthew Garrett <mjg@...hat.com>, Holger Macht <holger@...ac.de>,
	Lin Ming <minggr@...il.com>, Jeff Garzik <jgarzik@...hat.com>,
	Aaron Lu <aaron.lwe@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: bisected regression: v3.6-rc1: resume from s2ram does not
 restore ata_piix (v3.5 worked)

On Tue, 14 Aug 2012 16:09:52 +0800
Aaron Lu <ziqian.lu@...el.com> wrote:

> [Re-send due to the last email is not plain text.]
> 
> Hi Sergei,
> 
> The only problem I can see is the offending commit didn't do a gtm for
> IDE channel during init. It was used to be done in
> ata_acpi_associate_ide_port.
> 
> So can you please test if the following code fix your problem? Thanks.

Unfortunately, nothing changed. The same hangup after resume.
Did the bisected patch change the way kernel relies on ACPI
information? I have some complains in dmesg output about it
(attached whole dmesg) like that:

ACPI Exception: AE_AML_PACKAGE_LIMIT, Index (0x0000000000000004) is beyond end of object (20120711/exoparg2-418)
ACPI Error: Method parse/execution failed [\_SB_.C003.C09A._DOD] (Node ffff88007b82c988), AE_AML_PACKAGE_LIMIT (20120711/psparse-536)
ACPI Exception: AE_AML_PACKAGE_LIMIT, Evaluating _DOD (20120711/video-1149)
ata1: ACPI get timing mode failed (AE 0x1001)
ACPI: Invalid Power Resource to register!

They are not new errors.

> diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index 902b5a4..0f338bb 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -1101,6 +1101,9 @@ static int ata_acpi_bind_host(struct ata_port *ap, acpi_handle *handle)
>  	if (!*handle)
>  		return -ENODEV;
>  
> +	if (ata_acpi_gtm(ap, &ap->__acpi_init_gtm) == 0)
> +		ap->pflags |= ATA_PFLAG_INIT_GTM_VALID;
> +
>  	return 0;
>  }
> 
> Thanks,
> Aaron
> 
> > ---------- Forwarded message ----------
> > From: Sergei Trofimovich <slyich@...il.com>
> > Date: Mon, Aug 13, 2012 at 5:20 PM
> > Subject: bisected regression: v3.6-rc1: resume from s2ram does not restore ata_piix (v3.5 worked)
> > To: linux-pm@...ts.linux-foundation.org, Matthew Garrett <mjg@...hat.com>, Holger Macht <holger@...ac.de>, Lin Ming <ming.m.lin@...el.com>, Jeff Garzik <jgarzik@...hat.com>
> > Cc: linux-kernel@...r.kernel.org
> > 
> > 
> > It's a laptop compaq 2510p (~5 years old core2 laptop) with a single SATA drive:
> > 
> > 00:1f.1 IDE interface: Intel Corporation 82801HM/HEM (ICH8M/ICH8M-E) IDE Controller (rev 03)
> >         Subsystem: Hewlett-Packard Company Device 30c9
> >         Kernel driver in use: ata_piix
> > 
> > kernel v3.5 worked fine. 3.6-rc1 resumes, but disk stays inaccessble.
> > Seems to be 100% reproducible. Bisection gave sane result[1].
> > 
> > I was not able to revert it as-is, thus couldn't verify the revert helps on top of master.
> > 
> > Do you need more info?
> > 
> > Thanks!
> > 
> > [1]
> > commit 30dcf76acc695cbd2fa919e294670fe9552e16e7
> > Author: Matthew Garrett <mjg@...hat.com>
> > Date:   Mon Jun 25 16:13:04 2012 +0800
> > 
> >     libata: migrate ACPI code over to new bindings
> > 
> >     Now that we have the ability to directly glue the ACPI namespace to the
> >     driver model in libata, we don't need the custom code to handle the same
> >     thing. Remove it and migrate the functions over to the new code.
> > 
> >     Signed-off-by: Matthew Garrett <mjg@...hat.com>
> >     Signed-off-by: Holger Macht <holger@...ac.de>
> >     Signed-off-by: Lin Ming <ming.m.lin@...el.com>
> >     Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
> > 
> > :040000 040000 6a659a9d4a92b2085f6d0b58484cb2f82cd12cfa
> > 125fe5d5fa8b208a08792b03e752571d825465d2 M      drivers
> > :040000 040000 b7c3819be4e82ae6e2ac9688055aeb2bc1bc4ebd
> > 9cbc8fd15b147a178f723bcdb9e7c34f9868400f M      include

-- 

  Sergei

View attachment "dmesg.txt" of type "text/plain" (40617 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)