linux-kernel - Re: "regulator: Enable supply regulator if child rail is enabled" broken?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502A11A0.7070906@nvidia.com>
Date:	Tue, 14 Aug 2012 14:21:44 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Rabin Vincent <rabin@....in>
CC:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"lrg@...com" <lrg@...com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: "regulator: Enable supply regulator if child rail is enabled"
 broken?

On Tuesday 14 August 2012 02:08 PM, Rabin Vincent wrote:
> It appears that this patch causes incorrect reference counting on supply
> regulators if the child regulator is enabled with for example boot_on=true:
>
> commit b2296bd43e781976743354c668a356b0df98e1da
> Author: Laxman Dewangan<ldewangan@...dia.com>
> Date:   Mon Jan 2 13:08:45 2012 +0530
>
>      regulator: Enable supply regulator if child rail is enabled.
>
> If a regulator is enabled at boot (by constraints), then this patch calls
> regulator_enable() on the supply regulator, leading to a use_count increase on
> the supply.  However, this patch adds no code to perform the corresponding
> regulator_disable(), leaving the supply regulator on even when all consumers
> have disabled it.
>
> AFAICS, this patch would have only worked for always_on regulators.

Yaah, It is missing the regulator_disable() in regulator_init_complete() 
for some cases.
Please let me know if I need to send patch for fixing this issue.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/