linux-kernel - Re: [GIT PULL] gpio fixes for v3.6-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbRKfGSuY5A7BRH3rY0vMPxsKYBuzmqWZJNBawQMsAqog@mail.gmail.com>
Date:	Tue, 14 Aug 2012 14:38:19 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Grant Likely <grant.likely@...retlab.ca>,
	Shawn Guo <shawn.guo@...aro.org>,
	Daniel Mack <zonque@...il.com>, Axel Lin <axel.lin@...il.com>,
	Alan Cox <alan@...ux.intel.com>,
	Sean Paul <seanpaul@...omium.org>,
	Julia Lawall <Julia.Lawall@...6.fr>
Subject: Re: [GIT PULL] gpio fixes for v3.6-rc1

On Mon, Aug 13, 2012 at 4:36 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Friday 10 August 2012, Linus Walleij wrote:
>> Daniel Mack (1):
>>       GPIO: gpio-pxa: fix devicetree functions
>>
>
> Unfortunately, this one caused a build regression, see the fix below.
> I also wonder why pxa_irq_domain_ops isn't static.
>
>         Arnd
>
> 8<----
> GPIO: gpio-pxa: fix building without CONFIG_OF
>
> Patch 7212157267 "GPIO: gpio-pxa: fix devicetree functions" added an
> "xlate" function pointer to the irq_domain_ops, but this function
> is nor declared or defined anywhere when CONFIG_OF is disabled, causing
> the build error:
>
> drivers/gpio/gpio-pxa.c:532:11: error: 'irq_domain_xlate_twocell' undeclared here (not in a function)
>
> Extending the DT-only code section to cover the irq_domain_ops
> and the pxa_gpio_dt_ids solves this problem and makes it clearer
> which code is actually used without DT.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, applied this to my fixes branch.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/