linux-kernel - Re: [PATCH V6 4/5] USB: Add EHCI bus glue for Loongson1x SoCs (UPDATED)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2068844.Lgd4iRJr0U@flexo>
Date:	Tue, 14 Aug 2012 14:49:04 +0200
From:	Florian Fainelli <florian@...nwrt.org>
To:	Kelvin Cheung <keguang.zhang@...il.com>
Cc:	stern@...land.harvard.edu, linux-usb@...r.kernel.org,
	ralf@...ux-mips.org, linux-mips@...ux-mips.org, gregkh@...e.de,
	wuzhangjin@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V6 4/5] USB: Add EHCI bus glue for Loongson1x SoCs (UPDATED)

Hello Kelvin,

On Wednesday 18 January 2012 14:41:16 Kelvin Cheung wrote:
> Use ehci_setup() in ehci_ls1x_reset().
> 
> The Loongson1x SoCs have a built-in EHCI controller.
> This patch adds the necessary glue code to make the generic EHCI
> driver usable for them.
> 
> Signed-off-by: Kelvin Cheung <keguang.zhang@...il.com>
> ---

I do not see this driver doing anything fancy which would require an entirely 
new ehci implementation so consider using the generic ehci platform driver 
(drivers/usb/host/ehci-platforms.c) instead.

>  drivers/usb/Kconfig          |    1 +
>  drivers/usb/host/ehci-hcd.c  |    5 ++
>  drivers/usb/host/ehci-ls1x.c |  159 
++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 165 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/host/ehci-ls1x.c
> 
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 85d5a01..78ac78b 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -68,6 +68,7 @@ config USB_ARCH_HAS_EHCI
>  	default y if ARCH_MSM
>  	default y if MICROBLAZE
>  	default y if SPARC_LEON
> +	default y if MACH_LOONGSON1

Do this in arch/mips/Kconfig instead.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/