linux-kernel - Re: [PATCH V2] staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Aug 2012 19:30:02 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Devendra Naga <develkernel412222@...il.com>
Cc:	Javier Muñoz <jmunhoz@...lia.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Devendra Naga <devendra.aaru@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] staging: sm7xxfb: copy name of the device before
 calling smtc_alloc_fb_info

On Sat, Aug 04, 2012 at 11:10:20PM +0545, Devendra Naga wrote:
> as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in
> sm7xxx_probe is not having any assignment, and which leads to copying of the garbage value
> into the id field of the fix struct of fb interface struct. fix it by copying the name before
> calling alloc_fbinfo.
> 
> Signed-off-by: Devendra Naga <develkernel412222@...il.com>
> ---
> 
> Changes since V1:
>  Fix a null deref when smtc_alloc_fbinfo fails, this was added by me in V1.

Huh?  Please resend the correct patch you want me to apply, I'm confused
here.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/