linux-kernel - Re: [PATCH 6/6] workqueue: deprecate WQ_NON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120814173531.GP25632@google.com>
Date:	Tue, 14 Aug 2012 10:35:31 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Marc Dietrich <marvin24@....de>
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, mingo@...hat.com,
	lauro.venancio@...nbossa.org, jak@...-linux.org,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Alasdair Kergon <agk@...hat.com>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	Samuel Ortiz <sameo@...ux.intel.com>, Rob Clark <rob@...com>,
	Christine Caulfield <ccaulfie@...hat.com>,
	Steven Whitehouse <swhiteho@...hat.com>,
	Christoph Hellwig <hch@...radead.org>,
	Sage Weil <sage@...tank.com>
Subject: Re: [PATCH 6/6] workqueue: deprecate WQ_NON_REENTRANT

Hello,

On Tue, Aug 14, 2012 at 07:24:59PM +0200, Marc Dietrich wrote:
> the nvec driver had its own workqueue because we found that it reduced some 
> timimg induced protocol errors. I just tested your patch which uses the system 
> workqueue and I failed to reproduce these protocol errors under stress 
> testing, so I think it's ok.

Thanks, there shouldn't be any difference whether you use system_wq or
your own.

> Because this is a single patch affecting many drivers, is this going through 
> linux-next or some subsystem tree? Maybe it would have been better to split it 
> in one patch per driver. Otherwise ...

I generally think it's better to do quick one time conversion for
things like this, but this patch is rather borderline.  It might be
better to separate out the non trivialones and route them separately.
I'll think more about it.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/