linux-kernel - Re: [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120814201950.GA17781@quad.redhat.com>
Date:	Tue, 14 Aug 2012 16:19:50 -0400
From:	Andy Gospodarek <gospo@...hat.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	faisal.latif@...el.com, roland@...nel.org, sean.hefty@...el.com,
	hal.rosenstock@...il.com, fubar@...ibm.com, andy@...yhouse.net,
	divy@...lsio.com, jitendra.kalsaria@...gic.com,
	sony.chacko@...gic.com, linux-driver@...gic.com, kaber@...sh.net,
	ursula.braun@...ibm.com, blaschka@...ux.vnet.ibm.com,
	linux390@...ibm.com, shemminger@...tta.com,
	bhutchings@...arflare.com, therbert@...gle.com,
	xiyou.wangcong@...il.com, joe@...ches.com,
	gregory.v.rose@...el.com, john.r.fastabend@...el.com,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, bridge@...ts.linux-foundation.org,
	fbl@...hat.com
Subject: Re: [patch net-next v2 00/15] net: introduce upper device lists and
 remove dev->master

On Tue, Aug 14, 2012 at 05:05:33PM +0200, Jiri Pirko wrote:
> Hi all.
> 
> Recent discussion around
> "[net-next] bonding: don't allow the master to become its slave"
> forced me to think about upper<->lower device connections.
> 
> This patchset adds a possibility to record upper device linkage.
> All upper<->lower devices are converted to use this mechanism right after.
> That leads to dev->master removal because this info becomes redundant since
> "unique links" have the same value.
> 
> After all changes, there is no longer possible to do:
> "bond->someotherdevice->samebond"
> 
> Also I think that drivers like cxgb3, qlcnic, qeth would benefit by this
> in future by being able to get more appropriate info about l3 addresses.
> 
> v1->v2:
> - s/unique/master/ better naming + stays closer to the history
> - fixed vlan err goto
> - original patch 15 (WARN_ON change) is squashed into the first patch
> - fixed netdev_unique_upper_dev_get_rcu() case of upper==NULL
I just started to review v1 when v2 came out, but luckily the changes
were not too significant that I need to start all over.

The first note is that I didn't like the use of the term 'upper' -- it
seems like 'stacked' might be a better alternative as these are stacked
devices.

One thing to note is that I don't see any clear changelog that states
the current goals for this.  You have stated in several places that it
will no longer be possible to create bonds of bonds, but there are
probably a few more things it might be wise to intentionally outlaw.

What about teams of teams?  Or teams of bonds?  Or bonds of teams?
Bonds of vlans?

> 
> Jiri Pirko (15):
>   net: introduce upper device lists
>   macvlan: add link to upper device
>   vlan: add link to upper device
>   rtnetlink: remove usage of dev->master
>   team: remove usage of netdev_set_master()
>   bridge: remove usage of netdev_set_master()
>   netpoll: remove usage of dev->master
>   cxgb3: remove usage of dev->master
>   qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock
>   qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock
>   vlan: remove usage of dev->master in __vlan_find_dev_deep()
>   nes: remove usage of dev->master
>   bonding: remove usage of dev->master
>   net: remove no longer used netdev_set_bond_master() and
>     netdev_set_master()
>   net: kill dev->master
> 
>  drivers/infiniband/hw/nes/nes.c                    |    8 +-
>  drivers/infiniband/hw/nes/nes_cm.c                 |    2 +-
>  drivers/net/bonding/bond_3ad.c                     |   30 +--
>  drivers/net/bonding/bond_alb.c                     |    6 +-
>  drivers/net/bonding/bond_main.c                    |   94 ++++----
>  drivers/net/bonding/bonding.h                      |   14 +-
>  drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c |   11 +-
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |    2 +
>  drivers/net/macvlan.c                              |    9 +-
>  drivers/net/team/team.c                            |   13 +-
>  drivers/s390/net/qeth_l3_main.c                    |   21 +-
>  include/linux/netdevice.h                          |   22 +-
>  net/8021q/vlan.c                                   |   10 +-
>  net/8021q/vlan_core.c                              |   18 +-
>  net/bridge/br_if.c                                 |    6 +-
>  net/core/dev.c                                     |  239 +++++++++++++++++---
>  net/core/netpoll.c                                 |    8 +-
>  net/core/rtnetlink.c                               |   45 ++--
>  18 files changed, 391 insertions(+), 167 deletions(-)
> 
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/