lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Aug 2012 22:27:21 +0100 From: Al Viro <viro@...IV.linux.org.uk> To: Cyrill Gorcunov <gorcunov@...nvz.org> Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, Alexey Dobriyan <adobriyan@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, Pavel Emelyanov <xemul@...allels.com>, James Bottomley <jbottomley@...allels.com>, Matthew Helsley <matt.helsley@...il.com> Subject: Re: [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers On Tue, Aug 14, 2012 at 11:56:49PM +0400, Cyrill Gorcunov wrote: > Al, does the patch below looks better? If so I'll fix up the rest. > struct file_operations { > struct module *owner; > + struct seq_operations *fdinfo_ops; IDGI. Why on the earth do you need the whole iterator? All it takes is show_fdinfo(struct seq_file *m, struct file *f); have ->show() in your iterator (one going through the files) call that sucker for the file we are trying to show. I think you are severely overdesigning that thing... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists