linux-kernel - Re: Bug in UDF, setting larger file size when data in ICB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120814222238.GO7122@quack.suse.cz>
Date:	Wed, 15 Aug 2012 00:22:38 +0200
From:	Jan Kara <jack@...e.cz>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	lkml <linux-kernel@...r.kernel.org>, Jan Kara <jack@...e.cz>
Subject: Re: Bug in UDF, setting larger file size when data in ICB

On Mon 23-07-12 17:43:37, Ian Abbott wrote:
> On 2012-07-23 16:19, Ian Abbott wrote:
> >Hi folks,
> >
> >in fs/udf/inode.c, udf_setsize(), if the new size is larger than the old
> >size and the old data is in the ICB and the new size still fits in the
> >ICB (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB and iinfo->i_lenAlloc
> >= newsize), udf_extend_file() is called which promptly calls BUG()
> >because it does not like this i_alloc_type value.
> >
> >I think the simplest fix would be to add a 'goto' after the assignment
> >to iinfo->i_lenAlloc, bypassing the call to udf_extend_file().
> 
> Jan is on vacation until early August, so I submitted my own patch:
> 
> Date: Mon, 23 Jul 2012 17:39:29 +0100
> Subject: [PATCH] udf: fix udf_setsize() for file data in ICB
> Message-ID: <1343061569-3629-1-git-send-email-abbotti@....co.uk>
  Thanks for the patch. I've added it to my tree and will send it to Linus
soon.

								Honza

-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/