linux-kernel - Re: [PATCH RFT 1/2] gpio: gpio-ml-ioh: Use spinlock for register access protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120814092552.6e06305d@feng-i7>
Date:	Tue, 14 Aug 2012 09:25:52 +0800
From:	Feng Tang <feng.tang@...el.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Tomoya MORINAGA <tomoya.rohm@...il.com>,
	<linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Axel Lin <axel.lin@...il.com>
Subject: Re: [PATCH RFT 1/2] gpio: gpio-ml-ioh: Use spinlock for register
 access protection

On Mon, 13 Aug 2012 14:01:31 +0200
Linus Walleij <linus.walleij@...aro.org> wrote:

> On Sun, Jul 29, 2012 at 4:54 AM, Axel Lin <axel.lin@...il.com> wrote:
> 
> > gpio_chip.can_sleep is 0, but current code uses mutex in ioh_gpio_set,
> > ioh_gpio_get and ioh_gpio_direction_input functions.
> > Thus those functions are not callable from interrupt context.
> > This patch converts mutex into spinlock.
> >
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> 
> So IOH guys what are you saying about this?

I'm not the IOH guy, but just happened to work on it for some time :) Anyway,
the 2 patches both look good to me.

Thanks,
Feng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/