linux-kernel - Re: [PATCH 3/5] kmemleak: use rbtree instead of prio tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHkRjk4pQOktEGFZy9Jd5NDth8f_+JUC0OrgcRUaCFGUEUOTKg@mail.gmail.com>
Date:	Wed, 15 Aug 2012 17:36:35 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Michel Lespinasse <walken@...gle.com>
Cc:	"riel@...hat.com" <riel@...hat.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"vrajesh@...ch.edu" <vrajesh@...ch.edu>,
	"daniel.santos@...ox.com" <daniel.santos@...ox.com>,
	"aarcange@...hat.com" <aarcange@...hat.com>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3/5] kmemleak: use rbtree instead of prio tree

On 9 August 2012 09:31, Catalin Marinas <catalin.marinas@....com> wrote:
> On Wed, Aug 08, 2012 at 06:07:39PM +0100, Michel Lespinasse wrote:
>> kmemleak uses a tree where each node represents an allocated memory object
>> in order to quickly find out what object a given address is part of.
>> However, the objects don't overlap, so rbtrees are a better choice than
>> prio tree for this use. They are both faster and have lower memory overhead.
>>
>> Tested by booting a kernel with kmemleak enabled, loading the kmemleak_test
>> module, and looking for the expected messages.
>>
>> Signed-off-by: Michel Lespinasse <walken@...gle.com>
>
> The patch looks fine to me but I'll give it a test later today and let
> you know.

Couldn't test it because the patch got messed up somewhere on the
email path (tabs replaced with spaces). Is there a Git tree I can grab
it from (or you could just send it to me separately as attachment)?

Thanks,

Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/