linux-kernel - Re: [PATCH v3] Hardware breakpoints: Invoke __perf_event_disable() if interrupts are already disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502BDE3D.6070909@linux.vnet.ibm.com>
Date:	Wed, 15 Aug 2012 23:07:01 +0530
From:	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
To:	fweisbec@...il.com
CC:	a.p.zijlstra@...llo.nl, prasad.krishnan@...il.com,
	linux-kernel@...r.kernel.org, mingo@...hat.com, paulus@...ba.org,
	acme@...stprotocols.net, emachado@...ux.vnet.ibm.com
Subject: Re: [PATCH v3] Hardware breakpoints: Invoke __perf_event_disable()
 if interrupts are already disabled

Hi Frederick,
Did you get a chance to take a look at this?

Regards,
Naveen

On 08/02/2012 01:46 PM, Naveen N. Rao wrote:
> Hi Frederick,
> I've added a check to make sure we are targeting the current task. This
> applies on top of v3.5. Kindly review.
>
> Thanks,
> Naveen
>
> History:
> v3: Added check to make sure we only target "current" task.
> v2: Use __perf_event_disable() directly
> ______
>
> From: K.Prasad <Prasad.Krishnan@...il.com>
>
> While debugging a warning message on PowerPC while using hardware
> breakpoints, it was discovered that when perf_event_disable is invoked
> through hw_breakpoint_handler function with interrupts disabled, a
> subsequent IPI in the code path would trigger a WARN_ON_ONCE message in
> smp_call_function_single function.
>
> This patch calls __perf_event_disable() when interrupts are already
> disabled, instead of perf_event_disable().
>
> Reported-by: Edjunior Barbosa Machado <emachado@...ux.vnet.ibm.com>
> Signed-off-by: K.Prasad <Prasad.Krishnan@...il.com>
> [naveen.n.rao@...ux.vnet.ibm.com: v3: Check to make sure we target current task]
> Signed-off-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>
> ---
>   include/linux/perf_event.h    |    2 ++
>   kernel/events/core.c          |    2 +-
>   kernel/events/hw_breakpoint.c |   11 ++++++++++-
>   3 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 45db49f..c289ba0 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -1292,6 +1292,7 @@ extern int perf_swevent_get_recursion_context(void);
>   extern void perf_swevent_put_recursion_context(int rctx);
>   extern void perf_event_enable(struct perf_event *event);
>   extern void perf_event_disable(struct perf_event *event);
> +extern int __perf_event_disable(void *info);
>   extern void perf_event_task_tick(void);
>   #else
>   static inline void
> @@ -1330,6 +1331,7 @@ static inline int  perf_swevent_get_recursion_context(void)		{ return -1; }
>   static inline void perf_swevent_put_recursion_context(int rctx)		{ }
>   static inline void perf_event_enable(struct perf_event *event)		{ }
>   static inline void perf_event_disable(struct perf_event *event)		{ }
> +static inline int __perf_event_disable(void *info)			{ }
>   static inline void perf_event_task_tick(void)				{ }
>   #endif
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index d7d71d6..0ad0fc9 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -1253,7 +1253,7 @@ retry:
>   /*
>    * Cross CPU call to disable a performance event
>    */
> -static int __perf_event_disable(void *info)
> +int __perf_event_disable(void *info)
>   {
>   	struct perf_event *event = info;
>   	struct perf_event_context *ctx = event->ctx;
> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
> index bb38c4d..9a7b487 100644
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -453,7 +453,16 @@ int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *att
>   	int old_type = bp->attr.bp_type;
>   	int err = 0;
>
> -	perf_event_disable(bp);
> +	/*
> +	 * modify_user_hw_breakpoint can be invoked with IRQs disabled and hence it
> +	 * will not be possible to raise IPIs that invoke __perf_event_disable.
> +	 * So call the function directly after making sure we are targeting the
> +	 * current task.
> +	 */
> +	if (irqs_disabled() && bp->ctx && bp->ctx->task == current)
> +		__perf_event_disable(bp);
> +	else
> +		perf_event_disable(bp);
>
>   	bp->attr.bp_addr = attr->bp_addr;
>   	bp->attr.bp_type = attr->bp_type;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/