lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 15 Aug 2012 05:29:26 +0100
From:	Ben Hutchings <>
To:	Will Deacon <>,
	Russell King <>
Cc:,,,,, Arnd Bergmann <>,
	Nicolas Pitre <>,
	Shan Kang <>,
	Greg Kroah-Hartman <>
Subject: Re: [ 10/65] ARM: 7467/1: mutex: use generic xchg-based
 implementation for ARMv6+

On Mon, 2012-08-13 at 15:13 -0700, Greg Kroah-Hartman wrote:
> From: Greg KH <>
> 3.4-stable review patch.  If anyone has any objections, please let me know.
> ------------------
> From: Will Deacon <>
> commit a76d7bd96d65fa5119adba97e1b58d95f2e78829 upstream.
> The open-coded mutex implementation for ARMv6+ cores suffers from a
> severe lack of barriers, so in the uncontended case we don't actually
> protect any accesses performed during the critical section.
> Furthermore, the code is largely a duplication of the ARMv6+ atomic_dec
> code but optimised to remove a branch instruction, as the mutex fastpath
> was previously inlined. Now that this is executed out-of-line, we can
> reuse the atomic access code for the locking (in fact, we use the xchg
> code as this produces shorter critical sections).
> This patch uses the generic xchg based implementation for mutexes on
> ARMv6+, which introduces barriers to the lock/unlock operations and also
> has the benefit of removing a fair amount of inline assembly code.

I understand that a further fix is needed on top of this
<> but it's
not in Linus's tree yet.  Is it better to apply this on its own or to
wait for the complete fix?


Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)

Powered by blists - more mailing lists