linux-kernel - Re: [PATCH 01/13] vfs: add i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Aug 2012 06:28:32 +1000
From:	NeilBrown <neilb@...e.de>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Miklos Szeredi <miklos@...redi.hu>, viro@...IV.linux.org.uk,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	hch@...radead.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, apw@...onical.com, nbd@...nwrt.org,
	hramrach@...trum.cz, jordipujolp@...il.com, ezk@....cs.sunysb.edu,
	ricwheeler@...il.com, dhowells@...hat.com, hpj@...la.net,
	sedat.dilek@...glemail.com, penberg@...nel.org,
	goran.cetusic@...il.com, romain@...bokech.com, mszeredi@...e.cz
Subject: Re: [PATCH 01/13] vfs: add i_op->open()

On Wed, 15 Aug 2012 13:21:50 -0400 "J. Bruce Fields" <bfields@...ldses.org>
wrote:

> On Wed, Aug 15, 2012 at 05:48:08PM +0200, Miklos Szeredi wrote:
> > From: Miklos Szeredi <mszeredi@...e.cz>
> > 
> > Add a new inode operation i_op->open().  This is for stacked
> 
> Shouldn't that "->open()" be "->dentry_open()" ?
> 
> --b.
> 
> > filesystems that want to return a struct file from a different
> > filesystem.
> > 
> > Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
> > ---
> >  Documentation/filesystems/Locking |    2 ++
> >  Documentation/filesystems/vfs.txt |    7 +++++++
> >  fs/namei.c                        |    9 ++++++---
> >  fs/open.c                         |   23 +++++++++++++++++++++--
> >  include/linux/fs.h                |    2 ++
> >  5 files changed, 38 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking
> > index 0f103e3..d222b6a 100644
> > --- a/Documentation/filesystems/Locking
> > +++ b/Documentation/filesystems/Locking
> > @@ -64,6 +64,7 @@ prototypes:
> >  	int (*atomic_open)(struct inode *, struct dentry *,
> >  				struct file *, unsigned open_flag,
> >  				umode_t create_mode, int *opened);
> > +	int (*dentry_open)(struct dentry *, struct file *, const struct cred *);
> >  
> >  locking rules:
> >  	all may block
> > @@ -92,6 +93,7 @@ removexattr:	yes
> >  fiemap:		no
> >  update_time:	no
> >  atomic_open:	yes
> > +open:		no
> >  

and that last line should be
    +dentry_open:       no
??

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)