linux-kernel - Re: [PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120815150328.e1fb3676.akpm@linux-foundation.org>
Date:	Wed, 15 Aug 2012 15:03:28 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Michael Cree <mcree@...on.net.nz>, linux-alpha@...r.kernel.org,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Matt Turner <mattst88@...il.com>,
	Tony Luck <tony.luck@...il.com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	John David Anglin <dave.anglin@...l.net>,
	Mel Gorman <mgorman@...e.de>, kernel-janitors@...r.kernel.org,
	Kyle McMartin <kyle@...isc-linux.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Parisc List <linux-parisc@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64_INIT to drop
 the casts

On Sun, 12 Aug 2012 10:14:05 +0800
Fengguang Wu <fengguang.wu@...el.com> wrote:

> From: Mel Gorman <mgorman@...e.de>
> 
> The following build error occurred during an alpha build:
> 
> net/core/sock.c:274:36: error: initializer element is not constant
> 
> Dave Anglin says:
> > Here is the line in sock.i:
> >
> > struct static_key memalloc_socks = ((struct static_key) { .enabled =
> > ((atomic_t) { (0) }) });
> 
> The above line contains two compound literals.  It also uses a designated
> initializer to initialize the field enabled.  A compound literal is not a
> constant expression.
> 
> The location of the above statement isn't fully clear, but if a compound
> literal occurs outside the body of a function, the initializer list must
> consist of constant expressions.
> 
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Mel Gorman <mgorman@...e.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

I'll remvoe the Cc:stable from this one - the regression is post-3.5.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/