linux-kernel - Re: [PATCH v2 1/2] drivers/mfd: Add realtek pcie card reader driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201208150640.54561.arnd@arndb.de>
Date:	Wed, 15 Aug 2012 06:40:54 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	wei_wang@...lsil.com.cn
Cc:	gregkh@...uxfoundation.org, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
	cjb@...top.org, sameo@...ux.intel.com, bp@...en8.de,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v2 1/2] drivers/mfd: Add realtek pcie card reader driver

On Tuesday 14 August 2012, wei_wang@...lsil.com.cn wrote:
> +
> +void rtsx_pci_start_run(struct rtsx_pcr *pcr)
> +{
> +       /* If pci device removed, don't queue idle work any more */
> +       if (pcr->remove_pci)
> +               return;
> +
> +       if (pcr->state != PDEV_STAT_RUN) {
> +               pcr->state = PDEV_STAT_RUN;
> +               pcr->ops->enable_auto_blink(pcr);
> +       }
> +
> +       mod_timer(&pcr->idle_timer, jiffies + msecs_to_jiffies(200));
> +}
> +EXPORT_SYMBOL_GPL(rtsx_pci_start_run);

One more comment on the mod_timer/queue_work combination: I just saw that
Tejun Heo posted a series to introduce a new mod_delayed_work() helper.

Once that goes in, it would be best to start using it here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/