linux-kernel - Re: [PATCH] mtd: kill MTD_NAND_VERIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120815100655.479e2c39@pixies.home.jungo.com>
Date:	Wed, 15 Aug 2012 10:06:55 +0300
From:	Shmulik Ladkani <shmulik.ladkani@...il.com>
To:	Huang Shijie <shijie8@...il.com>
Cc:	dwmw2@...radead.org, dedekind1@...il.com,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

Hi Huang,

On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijie <shijie8@...il.com> wrote:
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 588e989..0ca7257 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -22,15 +22,6 @@ menuconfig MTD_NAND
>  
>  if MTD_NAND
>  
> -config MTD_NAND_VERIFY_WRITE
> -	bool "Verify NAND page writes"
> -	help
> -	  This adds an extra check when data is written to the flash. The
> -	  NAND flash device internally checks only bits transitioning
> -	  from 1 to 0. There is a rare possibility that even though the
> -	  device thinks the write was successful, a bit could have been
> -	  flipped accidentally due to device wear or something else.
> -

There are some defconfig files which set CONFIG_MTD_NAND_VERIFY_WRITE.

I guess you should submit an accompanying patch that removes
CONFIG_MTD_NAND_VERIFY_WRITE from all defconfig files.

(also, trimmed the CC list for this specific discussion, seems unrelated
to all of the parties)

Regards,
Shmulik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/