linux-kernel - Re: [PATCH 2/2] s390: Always use "long" for ssize_t to match size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120815080752.GC3622@osiris.de.ibm.com>
Date:	Wed, 15 Aug 2012 10:07:53 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-s390@...r.kernel.org
Subject: Re: [PATCH 2/2] s390: Always use "long" for ssize_t to match size_t

On Sun, Aug 12, 2012 at 12:01:34PM +0200, Geert Uytterhoeven wrote:
> On s390x-linux-gcc, __SIZE_TYPE__ expands to "long unsigned int" for both
> 32-bit s390 and 64-bit s390x, as
> gcc-4.6.3-nolibc/s390x-linux/lib/gcc/s390x-linux/4.6.3/plugin/include/config/s390/linux.h
> has
> 
>     #define SIZE_TYPE (TARGET_64BIT ? "long unsigned int" : "long unsigned int")
> 
> To match this, __kernel_size_t is always set to "long unsigned int".
> 
> But while __kernel_ssize_t is "long" on 64-bit s390x, it is "int" on 32-bit
> s390, causing compiler warnings like:
> 
>     fs/quota/quota_tree.c:372:4: warning: format '%zd' expects argument of type 'signed size_t', but argument 4 has type 'ssize_t' [-Wformat]
> 
> To fix this, __kernel_ssize_t should be "long", irrespective of word size.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied. Thanks Geert!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/