linux-kernel - Re: [PATCH V3 1/5] clk: mmp: add mmp specific clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201208160718.01769.arnd@arndb.de>
Date:	Thu, 16 Aug 2012 07:18:01 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Chao Xie <xiechao.mail@...il.com>
Cc:	haojian.zhuang@...il.com, mturquette@...aro.org,
	viresh.linux@...il.com, s.hauer@...gutronix.de,
	chao.xie@...vell.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3 1/5] clk: mmp: add mmp specific clocks

On Thursday 16 August 2012, Chao Xie wrote:
> +static int clk_apbc_prepare(struct clk_hw *hw)
> +{
> +       struct clk_apbc *apbc = to_clk_apbc(hw);
> +       unsigned int data;
> +       unsigned long flags = 0;
> +
> +       /*
> +        * It may share same register as MUX clock,
> +        * and it will impact FNCLK enable. Spinlock is needed
> +        */
> +       if (apbc->lock)
> +               spin_lock_irqsave(apbc->lock, flags);
> +
> +       data = __raw_readl(apbc->base);
> +       if (apbc->flags & APBC_POWER_CTRL)
> +               data |= APBC_POWER;
> +       data |= APBC_FNCLK;
> +       __raw_writel(data, apbc->base);

It seems you have missed a few __raw_readl/__raw_writel that still
want to get changed to readl_relaxed/writel_relaxed.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/