linux-kernel - Re: [PATCH] usb: hcd: use *resource_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120816125607.GB26408@arwen.pp.htv.fi>
Date:	Thu, 16 Aug 2012 15:56:08 +0300
From:	Felipe Balbi <balbi@...com>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, balbi@...com
Subject: Re: [PATCH] usb: hcd: use *resource_size_t* for specifying resource
 data

Hi,

On Thu, Aug 16, 2012 at 06:24:19PM +0530, Kishon Vijay Abraham I wrote:
> Changed the type of rsrc_start and rsrc_len from u64 to resource_size_t
> so that it behaves well with resource API's like *resource_size()* on both
> 32bit and 64bit devices.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>

looks correct to me. FWIW:

Acked-by: Felipe Balbi <balbi@...com>

> ---
>  include/linux/usb/hcd.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c5fdb14..608050b 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -135,8 +135,8 @@ struct usb_hcd {
>  
>  	unsigned int		irq;		/* irq allocated */
>  	void __iomem		*regs;		/* device memory/io */
> -	u64			rsrc_start;	/* memory/io resource start */
> -	u64			rsrc_len;	/* memory/io resource length */
> +	resource_size_t		rsrc_start;	/* memory/io resource start */
> +	resource_size_t		rsrc_len;	/* memory/io resource length */
>  	unsigned		power_budget;	/* in mA, 0 = no limit */
>  
>  	/* bandwidth_mutex should be taken before adding or removing
> -- 
> 1.7.9.5
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)