linux-kernel - Re: [patch] [SCSI] mvsas: fix a && vs & bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Aug 2012 11:23:44 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Xiangliang Yu <yuxiangl@...vell.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] [SCSI] mvsas: fix a && vs & bug

On 08/16/2012 07:04 AM, Dan Carpenter wrote:
> The "1 << (slot_idx % 32)" condition is always true.  The intent was to
> test a bit field here using bitwise AND.  We do the test correctly a few
> lines later in the do while loop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Jeff Garzik <jgarzik@...hat.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/