linux-kernel - Re: [PATCH 2/8] exofs: remove lock/unlock super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <502D1B32.7020005@gmail.com>
Date:	Thu, 16 Aug 2012 18:09:22 +0200
From:	Marco Stornelli <marco.stornelli@...il.com>
To:	Boaz Harrosh <bharrosh@...asas.com>
CC:	dedekind1@...il.com, bhalevy@...ian.com, jack@...e.cz,
	Andrew Morton <akpm@...ux-foundation.org>,
	adilger.kernel@...ger.ca, tytso@....edu,
	hirofumi@...l.parknet.co.jp, mikulas@...ax.karlin.mff.cuni.cz,
	Al Viro <viro@...IV.linux.org.uk>, hch@...radead.org,
	dushistov@...l.ru, osd-dev@...n-osd.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-ext4@...r.kernel.org,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 2/8] exofs: remove lock/unlock super

Il 16/08/2012 14:32, Boaz Harrosh ha scritto:
> On 08/16/2012 03:20 PM, Artem Bityutskiy wrote:
>
>> On Thu, 2012-08-16 at 12:00 +0200, Marco Stornelli wrote:
>>> From: Marco Stornelli <marco.stornelli@...il.com>
>>>
>>> Remove lock and unlock super operation.
>>>
>>> Signed-off-by: Marco Stornelli <marco.stornelli@...il.com>
>>
>> Acked-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
>>
>
>
> Are you sure? It used to be that exofs_sync_fs() could be called
> concurrently.
>
> What about two "bash -c sync" calls or a sync and an unmount
> in parallel. anything protecting that?
>
> If so then sure, but please let me test first.
> Boaz
>
> .
>

Yes Boaz, I agree, it's the reason I asked for a comments for exofs and 
hpfs. The only reason to have a lock here is to serialize operations in 
parallel on the same super block.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/