linux-kernel - Re: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1208161232001.31195-100000@netrider.rowland.org>
Date:	Thu, 16 Aug 2012 12:32:51 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Miklos Szeredi <miklos@...redi.hu>
cc:	Hans de Goede <hdegoede@...hat.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tejun Heo <tj@...nel.org>, <linux-kernel@...r.kernel.org>,
	<linux-pm@...r.kernel.org>
Subject: Re: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook

On Thu, 16 Aug 2012, Miklos Szeredi wrote:

> Yes, this appears to work.  Following patch fixes the suspend oops.
> 
> Thanks,
> Miklos
> 
> ---
>  drivers/ide/ide-pm.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c
> index 9240609..8d1e32d 100644
> --- a/drivers/ide/ide-pm.c
> +++ b/drivers/ide/ide-pm.c
> @@ -4,7 +4,7 @@
>  
>  int generic_ide_suspend(struct device *dev, pm_message_t mesg)
>  {
> -	ide_drive_t *drive = dev_get_drvdata(dev);
> +	ide_drive_t *drive = to_ide_device(dev);
>  	ide_drive_t *pair = ide_get_pair_dev(drive);
>  	ide_hwif_t *hwif = drive->hwif;
>  	struct request *rq;
> @@ -40,7 +40,7 @@ int generic_ide_suspend(struct device *dev, pm_message_t mesg)
>  
>  int generic_ide_resume(struct device *dev)
>  {
> -	ide_drive_t *drive = dev_get_drvdata(dev);
> +	ide_drive_t *drive = to_ide_device(dev);
>  	ide_drive_t *pair = ide_get_pair_dev(drive);
>  	ide_hwif_t *hwif = drive->hwif;
>  	struct request *rq;

And now you can get rid of the useless dev_set_drvdata() call.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/