lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Aug 2012 12:01:44 +0400 From: Ilya Shchepetkov <shchepetkov@...ras.ru> To: "David S. Miller" <davem@...emloft.net> Cc: Ilya Shchepetkov <shchepetkov@...ras.ru>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, ldv-project@...ras.ru Subject: Re: [PATCH] net: Fix incorrect comment in netif_tx_stop_queue() > > netif_stop_queue() can be called before register_netdev() because now > > TX queues are allocated inside alloc_netdev_mqs(). > > > > (since ed9af2e839c06c18f721da2c768fbb444c4a10e5 commit) > > > > Found by Linux Driver Verification project (linuxtesting.org). > > > > Signed-off-by: Ilya Shchepetkov <shchepetkov@...ras.ru> > > You're not changing a "comment", you're changing a kernel log message. > > Have you actually triggered this condition? > > I doubt it, and I'm not applying this patch. My test driver calls netif_carrier_off before register_netdev and works well, without "netif_stop_queue() cannot be called before register_netdev()" message. Also, there are drivers that call netif_tx_stop_queue directly and possible error message (with a reference to netif_stop_queue) will be wrong. Look at these commits: e6484930d7c73d324bccda7d43d131088da697b9 18543a643fae694982c7d89c22436885f3506497 ed9af2e839c06c18f721da2c768fbb444c4a10e5 After the third commit, the second one became unnecessary. Thus, I suggest either to remove the misleading message, or to replace it with this: pr_info("netif_tx_stop_queue(): dev_queue is null()\n"); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists