linux-kernel - Re: linux-next: build failure after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120817105633.0aba80ddf7eb9523e04c264d@canb.auug.org.au>
Date:	Fri, 17 Aug 2012 10:56:33 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	paulmck@...ux.vnet.ibm.com
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	Namhyung Kim <namhyung@...nel.org>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Subject: Re: linux-next: build failure after merge of the tip tree

Hi Paul,

On Thu, 16 Aug 2012 12:46:51 -0700 "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote:
>
> On Thu, Aug 16, 2012 at 01:12:36PM +1000, Stephen Rothwell wrote:
> > 
> > After merging the tip tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/infiniband/hw/ehca/ehca_irq.c: In function 'find_next_online_cpu':
> > drivers/infiniband/hw/ehca/ehca_irq.c:672:2: error: expected ';' before 'spin_unlock_irqrestore'
> > 
> > Caused by commit 81942621bd6b ("infiniband: Ehca: Use hotplug thread
> > infrastructure").
> > 
> > I have used the tip tree from next-20120814 for today.
> 
> My first reaction was "we tested that!!!", but I see the conversion
> from while(1) to do-while.  Does the following cure it?

Yes, that fixes the build problem.

However, the same commit is also responsible for all these new warnings:

drivers/infiniband/hw/ehca/ehca_irq.c: In function 'queue_comp_task':
drivers/infiniband/hw/ehca/ehca_irq.c:710:9: warning: assignment from incompatible pointer type
drivers/infiniband/hw/ehca/ehca_irq.c:719:10: warning: assignment from incompatible pointer type
drivers/infiniband/hw/ehca/ehca_irq.c: In function 'comp_task_park':
drivers/infiniband/hw/ehca/ehca_irq.c:764:9: warning: assignment from incompatible pointer type
drivers/infiniband/hw/ehca/ehca_irq.c: In function 'comp_task':
drivers/infiniband/hw/ehca/ehca_irq.c:803:1: warning: no return statement in function returning non-void
drivers/infiniband/hw/ehca/ehca_irq.c: At top level:
drivers/infiniband/hw/ehca/ehca_irq.c:807:2: warning: initialization from incompatible pointer type

Please address these.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped