linux-kernel - Re: [PATCH] twl4030: It would be better not to use the 0b-prefix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Aug 2012 19:30:46 +1000
From:	NeilBrown <neilb@...e.de>
To:	Il Han <corone.il.han@...il.com>
Cc:	Anton Vorontsov <cbou@...l.ru>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, Chris Ball <cjb@...top.org>,
	"werner" <w.landgraf@...ru>
Subject: Re: [PATCH] twl4030: It would be better not to use the 0b-prefix.

On Fri, 17 Aug 2012 16:49:43 +0900 Il Han <corone.il.han@...il.com> wrote:

> It would be better not to use the 0b-prefix for earlier versions of gcc-4.3.
> Please, Modify it.
> 
> Signed-off-by: Il Han <corone.il.han@...il.com>
> ---
>  drivers/power/twl4030_charger.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
> index 15f4d5d..8d6bc68 100644
> --- a/drivers/power/twl4030_charger.c
> +++ b/drivers/power/twl4030_charger.c
> @@ -41,16 +41,16 @@
>  #define TWL4030_STS_VBUS	BIT(7)
>  #define TWL4030_STS_USB_ID	BIT(2)
>  #define TWL4030_BBCHEN		BIT(4)
> -#define TWL4030_BBSEL_MASK	0b1100
> -#define TWL4030_BBSEL_2V5	0b0000
> -#define TWL4030_BBSEL_3V0	0b0100
> -#define TWL4030_BBSEL_3V1	0b1000
> -#define TWL4030_BBSEL_3V2	0b1100
> -#define TWL4030_BBISEL_MASK	0b11
> -#define TWL4030_BBISEL_25uA	0b00
> -#define TWL4030_BBISEL_150uA	0b01
> -#define TWL4030_BBISEL_500uA	0b10
> -#define TWL4030_BBISEL_1000uA	0b11
> +#define TWL4030_BBSEL_MASK	0x0c
> +#define TWL4030_BBSEL_2V5	0x00
> +#define TWL4030_BBSEL_3V0	0x04
> +#define TWL4030_BBSEL_3V1	0x08
> +#define TWL4030_BBSEL_3V2	0x0c
> +#define TWL4030_BBISEL_MASK	0x03
> +#define TWL4030_BBISEL_25uA	0x00
> +#define TWL4030_BBISEL_150uA	0x01
> +#define TWL4030_BBISEL_500uA	0x02
> +#define TWL4030_BBISEL_1000uA	0x03
>  
>  /* BCI interrupts */
>  #define TWL4030_WOVF		BIT(0) /* Watchdog overflow */

Thanks.  I'd been meaning to send that patch, but life got in the way
recently.

Acked-by: NeilBrown <neilb@...e.de>

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)