linux-kernel - Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120817110256.GG4651@arwen.pp.htv.fi>
Date:	Fri, 17 Aug 2012 14:02:57 +0300
From:	Felipe Balbi <balbi@...com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:	balbi@...com, Roland Stigge <stigge@...com.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, arnd@...db.de, aletes.xgr@...il.com,
	kevin.wells@....com, srinivas.bakki@....com
Subject: Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop
 interface

On Fri, Aug 17, 2012 at 01:01:44PM +0200, Sebastian Andrzej Siewior wrote:
> On 08/17/2012 12:51 PM, Felipe Balbi wrote:
> >>Sounds reasonable?
> >
> >no it doesn't. Please remove that static global. Sorry but one of the
> >goals with udc_start/udc_stop was really to get rid of all those
> >nonsensical static globals.
> 
> I wouldn't insist on it. If you look at pxa25x, " static struct
> pxa25x_udc memory = {" they do the same thing. It is only a simple way
> to onetime initialize variables.

fair enough. Though that's wrong too and should be changed. The whole
idea of allowing multiple UDCs on the same kernel image is mostly to aid
development. Specially on pre-silicon phase. We could have a bunch of
PCIe FPGA boards and instantiate a different controller on each one and
have the same kernel work with them all.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)