linux-kernel - Re: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1208171025330.25520-100000@netrider.rowland.org>
Date:	Fri, 17 Aug 2012 10:27:20 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Hans de Goede <hdegoede@...hat.com>
cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Miklos Szeredi <miklos@...redi.hu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tejun Heo <tj@...nel.org>, <linux-kernel@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook

On Fri, 17 Aug 2012, Alan Stern wrote:

> On Fri, 17 Aug 2012, Hans de Goede wrote:
> 
> > No my patch was a hack to undo the results of the commit causing
> > the regression in the IDE case. But Alan's approach clearly is
> > much better! Once we are sure drvdata is not used anywhere the
> > dev_set_drvdata call could be removed in the place where my
> > hack added a second call to it. Note that there are likely
> > actual ide drivers using it, without setting it themselves since
> > the ide core was setting it. So removing it will require even more
> > auditing / checking.
> 
> I did search for dev_get_drvdata() calls in drivers/ide; there were no 
> other calls that retrieved an ide_drive_t value.  But I didn't check 
> anywhere else in the kernel.  In fact, I'm not sure where else to look.

After a little more checking: Among all the .c files in the kernel
which match the pattern '[^a-z]ide_', the only occurrences of
dev_get_drvdata() which retrieve an ide_drive_t value are the two in
ide-pm.c.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/