linux-kernel - Re: [RFC PATCH v2] trace: Move trace event enable from fs_initcall to early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALF0-+UWkZmAnW0TM0FwLPUp8UKRzBLh1i+5vDih9V8yQ8r+KA@mail.gmail.com>
Date:	Fri, 17 Aug 2012 13:56:07 -0300
From:	Ezequiel Garcia <elezegarcia@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Pekka Enberg <penberg@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, tim.bird@...sony.com,
	lizefan@...wei.com
Subject: Re: [RFC PATCH v2] trace: Move trace event enable from fs_initcall to early_initcall

On Fri, Aug 17, 2012 at 12:28 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Fri, 2012-08-17 at 09:03 -0300, Ezequiel Garcia wrote:
>> This patch splits trace event initialization in two stages:
>>  * ftrace enable
>>  * sysfs event entry creation
>>
>> This allows to capture trace events from an earlier point
>> by using 'trace_event' kernel parameter and is important
>> to trace boot-up allocations.
>>
>
> This is much better, I'll give it some tests and add it to my 3.7 queue.
>

Great. Is the event_remove() code, okey? I wasn't too sure about this part.

And also: do you think we could try to only early-enable those events
that were setup with 'trace_event' boot parameter?

I tried but couldn't do it without looping through the complete
__start_ftrace_event array and comparing each entry.

Is this even worthy?

Thanks for reviewing,
Ezequiel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/