linux-kernel - Re: [PATCH v1 2/3] PM / Sleep: introduce dpm_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVMxGCGJ+a=rfcCAqRuUMLG9OD3X52MMzTcfYOT4cepBGQ@mail.gmail.com>
Date:	Sat, 18 Aug 2012 22:52:31 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Borislav Petkov <borislav.petkov@....com>,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 2/3] PM / Sleep: introduce dpm_for_each_dev

On Sat, Aug 18, 2012 at 9:38 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
>
> My question was about the number of current users of it.  Sorry for not
> being clear.

Sorry for misunderstanding your question.

>
> If there are no more anticipated users than the current only one, please
> drop the unused (void *) argument.  We can always extend it in the future
> if need be and for now passing that NULL every time is just pointless.

One usage is to get statistics info about devices for debug purpose,
so the parameter is needed to return something.

> And please fold [2/3] into [3/3] in this series.

IMO, it is better to split them to avoid coupling between fw loader and
device PM.

Looks you agreed on the patch, and Greg has added the
patch into his driver-core next tree to fix -next build failure, so could
you just let them be that?

>
> I'm not particuarly fond of this patch, but I guess it would require some
> consderable juggling of #ifdefs to fix the build breakage in a different way.

Firmware loader might be built as module, so without exporting something
from device PM core, the problem can't be fixed.


Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/