linux-kernel - Re: [bisected] Driver core fixes for 3.6-rc3 regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Aug 2012 11:37:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	Jim Cromie <jim.cromie@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Kay Sievers <kay@...y.org>,
	Jason Baron <jbaron@...hat.com>
Subject: Re: [bisected] Driver core fixes for 3.6-rc3 regression

On Sat, 2012-08-18 at 09:34 -0700, Greg KH wrote:
> On Sat, Aug 18, 2012 at 08:09:34AM +0200, Markus Trippelsdorf wrote:
> > On 2012.08.17 at 10:13 -0700, Greg KH wrote:
> > > ----------------------------------------------------------------
> > > Driver core fixes for 3.6-rc3
> > > 
> > > Here are two tiny patches, one fixing a dynamic debug problem that the printk
> > > rework turned up, and the other one fixing an extcon problem that people
> > > reported.
> > > 
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > 
> > > ----------------------------------------------------------------
> > > Axel Lin (1):
> > >       extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one
> > > 
> > > Jim Cromie (1):
> > >       drivers-core: make structured logging play nice with dynamic-debug
> > 
> > The commit af7f2158f above causes hundreds of "Failed to force enable
> > HPET" messages to appear during boot on my system.
> > Please also note the strange "^A0" character sequence that is also
> > introduced by the same commit.
> 
> Ugh, I see the same thing here, debugging must be accidentally enabled
> with this patch, and the ^A0 stuff is just a mess.  Sorry, I didn't
> notice this in my testing, my fault.

It's a combination interaction because of the patch with
a conversion of KERN_<LEVEL> from "<.>" to concatenated
SOH "."

commit: 04d2c8c83d0e3ac5f78aeede51babb3236200112
																			
> Reverting this resolves the issue for me.
> 
> Jim, any thoughts on how to fix this?  Should I just revert this patch
> for now?

I have a patch to resolve dynamic debug logging.
I'll submit it Monday along with an updated netdev_printk patch.

Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/