linux-kernel - Re: [PATCH 3/8] ext3: remove lock/unlock super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <502F3F10.9070307@gmail.com>
Date:	Sat, 18 Aug 2012 09:06:56 +0200
From:	Marco Stornelli <marco.stornelli@...il.com>
To:	Theodore Ts'o <tytso@....edu>, Al Viro <viro@...IV.linux.org.uk>
CC:	Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>,
	adilger.kernel@...ger.ca, dushistov@...l.ru, bharrosh@...asas.com,
	bhalevy@...ian.com, hirofumi@...l.parknet.co.jp,
	mikulas@...ax.karlin.mff.cuni.cz, hch@...radead.org,
	osd-dev@...n-osd.org, Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-ext4@...r.kernel.org,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 3/8] ext3: remove lock/unlock super

Il 18/08/2012 01:08, Theodore Ts'o ha scritto:
> On Fri, Aug 17, 2012 at 08:47:04AM +0200, Marco Stornelli wrote:
>> Great. I'll remove the calls for ext3/ext4 when I'll submit the
>> second version of the patch.
>
> FYI, I have the following patch my ext4 tree, so I could do more
> intensive testing.  I'll let folks know if anything goes horribly
> wrong, but I'm pretty sure this should be safe.

Yeah, I'm agree. It should be safe.

>
>         	   	     	      	   	    - Ted
>
>>>From 81f74e743344217487792e4190f9478963d1bb21 Mon Sep 17 00:00:00 2001
> From: Theodore Ts'o <tytso@....edu>
> Date: Fri, 17 Aug 2012 19:00:34 -0400
> Subject: [PATCH] ext4: drop lock_super()/unlock_super()
>
> We don't need lock_super()/unlock_super() any more, since the places
> where it is used, we are protected by the s_umount r/w semaphore.
>
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> Cc: Marco Stornelli <marco.stornelli@...il.com>
> ---

I think the patches will go via Al's tree so if Al is agree I'll submit 
the patches without modify ext4 at this point. Al, let me know if we 
want to proceed in a different way.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/