linux-kernel - Re: [PATCH] i2c: tegra: Fix ifdefs for suspend mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120818121216.GA12839@pengutronix.de>
Date:	Sat, 18 Aug 2012 14:12:16 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Laxman Dewangan <ldewangan@...dia.com>, khali@...ux-fr.org,
	swarren@...dia.com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: tegra: Fix ifdefs for suspend mode

On Sat, Aug 18, 2012 at 01:01:38PM +0100, Mark Brown wrote:
> On Sat, Aug 18, 2012 at 09:07:32AM +0200, Wolfram Sang wrote:
> > On Mon, Jul 30, 2012 at 07:03:07PM +0530, Laxman Dewangan wrote:
> > > CONFIG_PM covers runtime only PM.
> 
> > I am a bit confused by this description. CONFIG_PM_RUNTIME covers
> > runtime PM, no?
> 
> The issue is that CONFIG_PM doesn't actually enable any of the PM
> callbacks, it only allows you to enable CONFIG_PM_SLEEP and
> CONFIG_PM_RUNTIME.  This means that if you use CONFIG_PM to protect your
> system sleep callbacks they may end up unreferenced if only runtime PM
> is enabled.

Thanks for the explanation!

Laxman, could you update the description to reflect that?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)