linux-kernel - Re: [PATCH 03/74] sections: Make external kallsyms tables _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5030A96F020000780008A1F1@nat28.tlf.novell.com>
Date:	Sun, 19 Aug 2012 08:53:03 +0100
From:	"Jan Beulich" <jbeulich@...e.com>
To:	<andi@...stfloor.org>, <ak@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>
Cc:	<x86@...nel.org>, <akpm@...ux-foundation.org>, <mmarek@...e.cz>,
	<linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH 03/74] sections: Make external kallsyms tables
 __visible

>>> Andi Kleen <andi@...stfloor.org> 08/19/12 5:02 AM >>>
>-extern const unsigned long kallsyms_addresses[] __attribute__((weak));
>-extern const u8 kallsyms_names[] __attribute__((weak));
>+extern __visible const unsigned long kallsyms_addresses[] __attribute__((weak));
>+extern __visible const u8 kallsyms_names[] __attribute__((weak));
 
Shouldn't we minimally aim at consistency here:
- all attributes in a one place (I personally prefer the placement between type
  and name, for compatibility with other compilers, but there are rare cases -
  iirc not on declarations though - where gcc doesn't allow this)
- not using open coded __attribute__(()) when a definition (here: __weak) is
  available, or alternatively open coding all of them (__attribute__((weak, ...)))?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/