linux-kernel - Re: [PATCH] Extcon: Minor change in the declaration of cable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <28057486.209671345445798709.JavaMail.weblogic@epml13>
Date:	Mon, 20 Aug 2012 06:56:39 +0000 (GMT)
From:	함명주 <myungjoo.ham@...sung.com>
To:	anish kumar <anish198519851985@...il.com>
Cc:	최찬우 <cw00.choi@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Extcon: Minor change in the declaration of cable_names

> From: anish kumar <anish198519851985@...il.com>
> 
> Instead of "const char **supported_cable" it is better to have
> it as "const char *const *supported_cable".
> 
> Signed-off-by: anish kumar <anish198519851985@...il.com>

Could you please elaborate on why it's better?

(Is this fixing the using the standard naming issue Mark mentioned before?)


Cheers!
MyungJoo

> ---
>  include/linux/extcon.h                 |    2 +-
>  include/linux/extcon/extcon-adc-jack.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index cdd4014..a6bcc29 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -111,7 +111,7 @@ struct extcon_cable;
>  struct extcon_dev {
>  	/* --- Optional user initializing data --- */
>  	const char	*name;
> -	const char **supported_cable;
> +	const char *const *supported_cable;
>  	const u32	*mutually_exclusive;
>  
>  	/* --- Optional callbacks to override class functions --- */
> diff --git a/include/linux/extcon/extcon-adc-jack.h b/include/linux/extcon/extcon-adc-jack.h
> index 20e9eef..f27f2e8 100644
> --- a/include/linux/extcon/extcon-adc-jack.h
> +++ b/include/linux/extcon/extcon-adc-jack.h
> @@ -60,7 +60,7 @@ struct adc_jack_pdata {
>  	/*
>  	 * The last entry should be NULL
>  	 */
> -	const char **cable_names;
> +	const char *const *cable_names;
>  	/* The last entry's state should be 0 */
>  	struct adc_jack_cond *adc_conditions;
>  
> -- 
> 1.7.1
> 
> 
> 
> 
>        
>   
>          
>