linux-kernel - Re: [PATCH] leds-lm3530: replace pwm platform functions with generic pwm functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120820073141.GA27645@avionic-0098.mockup.avionic-design.de>
Date:	Mon, 20 Aug 2012 09:31:42 +0200
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	Bryan Wu <bryan.wu@...onical.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] leds-lm3530: replace pwm platform functions with generic
 pwm functions

On Mon, Aug 20, 2012 at 06:16:41AM +0000, Kim, Milo wrote:
> > > * Rather than having to do the #ifdef here, I think it would be
> > better if
> > >   the PWM subsystem provided stub functions for pwm_request,
> > pwm_config,
> > >   pwm_enable, pwm_disable and pwm_free that do nothing, so you can in
> > effect
> > >   let the compiler optimize away the above code.
> > 
> > That's actually on my TODO list, but I think it needs to wait until we
> > have gotten rid of all legacy implementations. The stubs would have to
> > move into the !CONFIG_PWM branch, which will in turn break because the
> > legacy implementations would provide non-inlined duplicates.
> > 
> > Thierry
> 
> OK, then it's better to wait fixing that first.
> 
> Bryan,
> please just ignore this patch.
> I'll resend the patch later.

Maybe we should get this resolved somehow in the meantime. Resolving the
other issues may take another cycle or two, so you may not want to wait
that long.

Thierry

Content of type "application/pgp-signature" skipped