[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50324439.1000307@redhat.com>
Date: Mon, 20 Aug 2012 16:05:45 +0200
From: Paolo Bonzini <pbonzini@...hat.com>
To: "Richard W.M. Jones" <rjones@...hat.com>
CC: linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
> From: "Richard W.M. Jones" <rjones@...hat.com>
>
> The sg struct is used without being initialized.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=847548
>
> Signed-off-by: Richard W.M. Jones <rjones@...hat.com>
> ---
> drivers/scsi/virtio_scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index c7030fb..8a66f83 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
> struct scatterlist sg;
> unsigned long flags;
>
> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>
> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
>
>
Acked-by: Paolo Bonzini <pbonzini@...hat.com>
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists