lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Aug 2012 16:59:19 +0200 From: Oleg Nesterov <oleg@...hat.com> To: Peter Zijlstra <peterz@...radead.org> Cc: Dave Jones <davej@...hat.com>, Linux Kernel <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, rostedt <rostedt@...dmis.org>, dhowells <dhowells@...hat.com>, Al Viro <viro@...iv.linux.org.uk> Subject: Re: lockdep trace from posix timers On 08/20, Peter Zijlstra wrote: > > task_work_cancel(struct task_struct *task, task_work_func_t func) > { > ... > + > +again: > + workp = &task->task_works; > + work = *workp; > + while (work) { > + if (work->func == func) { But this all can race with task_work_run() if task != current. This "work" can be freed/reused. And it should only return !NULL if twork->func() was not called. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists