linux-kernel - Re: [PATCH v6 1/4] xattr: extract simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120820190039.GR25353@redhat.com>
Date:	Mon, 20 Aug 2012 15:00:39 -0400
From:	Aristeu Rozanski <aris@...hat.com>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org, Li Zefan <lizefan@...wei.com>,
	Hillf Danton <dhillf@...il.com>,
	Lennart Poettering <lpoetter@...hat.com>
Subject: Re: [PATCH v6 1/4] xattr: extract simple_xattr code from tmpfs

On Mon, Aug 20, 2012 at 12:10:09AM -0700, Hugh Dickins wrote:
> Yes, it looks nice to me.  I might have preferred more as inlines in
> the header file to lower the slight init/evict overhead, and I don't
> see why __simple_xattr_set() isn't using simple_xattr_alloc() in the
> same way that shmem_xattr_set() used shmem_xattr_alloc().  But none
> of that matters:
> 
> Acked-by: Hugh Dickins <hughd@...gle.com>

I can submit additional patches to fix these. What functions you want
inlined?

On why __simple_xattr_set() is not using simple_xattr_alloc(), there's
no reason to be that way, I missed it.

Thanks for reviewing!

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/