linux-kernel - Re: [PATCH] regulator: max8907: fix compile error when !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120820195756.GP26991@opensource.wolfsonmicro.com>
Date:	Mon, 20 Aug 2012 20:57:56 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	Axel Lin <axel.lin@...il.com>,
	Gyungoh Yoo <jack.yoo@...im-ic.com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH] regulator: max8907: fix compile error when !CONFIG_OF

On Mon, Aug 20, 2012 at 09:39:10AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@...dia.com>
> 
> Fix the following:

Applied, thanks.

> Note: It's possible that the MAX8907 PMIC is only used with Tegra; there
> certainly is a reference to AP15 (an old Tegra version) in the MAX8907
> documentation. If so, Tegra implies CONFIG_OF, so we could just make
> MAX8907 depend on CONFIG_OF and remove all the ifdefs from the driver.
> That said, I'm not at all sure whether the MAX8907 is Tegra-specific.

I think this would be a step backwards, if it's that hard to make DT
optional we ought to look at the DT infrastructure.  Otherwise build
coverage is good.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)