linux-kernel - Re: [PATCH] USB: Build usb_speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1208201639050.1182-100000@iolanthe.rowland.org>
Date:	Mon, 20 Aug 2012 16:42:44 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Andi Kleen <ak@...ux.intel.com>
cc:	Andi Kleen <andi@...stfloor.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <greg@...ah.com>
Subject: Re: [PATCH] USB: Build usb_speed_string unconditionally

On Mon, 20 Aug 2012, Andi Kleen wrote:

> On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote:
> > On Mon, 20 Aug 2012, Andi Kleen wrote:
> > 
> > > From: Andi Kleen <ak@...ux.intel.com>
> > > 
> > > The usb core uses usb_speed_string(). But it's only selected
> > > for USB_GADGET. Enable it unconditionally.
> > 
> > What are you talking about?  USB_COMMON isn't selected at all, but it
> > does get built whenever USB or USB_GAGDET is enabled.  From
> > drivers/usb/Kconfig:
> 
> Just trying to fix my LTO randconfigs.
> 
> Here's a config that violated it on rc2.

Okay, I see the problem.  Your config has:

# CONFIG_USB_SUPPORT is not set
CONFIG_USB=m

That combination should not be possible, because in 
drivers/usb/Kconfig, the definition of USB is inside an "if 
USB_SUPPORT" block.

Runing "make oldconfig" shows that this happened because:

warning: (MOUSE_APPLETOUCH && MOUSE_BCM5974 && MOUSE_SYNAPTICS_USB && JOYSTICK_XPAD && TABLET_USB_ACECAD && TABLET_USB_AIPTEK && TABLET_USB_HANWANG && TABLET_USB_KBTAB && TABLET_USB_WACOM && TOUCHSCREEN_USB_COMPOSITE && INPUT_ATI_REMOTE2 && INPUT_KEYSPAN_REMOTE && INPUT_POWERMATE && INPUT_YEALINK && INPUT_CM109 && RC_ATI_REMOTE && IR_IMON && IR_MCEUSB && IR_REDRAT3 && IR_STREAMZAP && IR_IGUANA && DRM_USB) selects USB which has unmet direct dependencies (USB_SUPPORT && USB_ARCH_HAS_HCD)

The culprit is DRM_USB, and I think Greg has just accepted a patch to 
fix it.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/