lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120820221122.56c11282@pyramind.ukuu.org.uk>
Date:	Mon, 20 Aug 2012 22:11:22 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Corentin Chary <corentin.chary@...il.com>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>, linux-acpi@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>,
	acpi4asus-user@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] asus-laptop: HRWS/HWRS typo

On Mon, 20 Aug 2012 23:01:51 +0200
Corentin Chary <corentin.chary@...il.com> wrote:

> Signed-off-by: Corentin Chary <corentin.chary@...il.com>
> ---
>  drivers/platform/x86/asus-laptop.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index e38f91b..110c777 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -863,9 +863,9 @@ static ssize_t show_infos(struct device *dev,
>  	 * The significance of others is yet to be found.
>  	 * If we don't find the method, we assume the device are present.
>  	 */
> -	rv = acpi_evaluate_integer(asus->handle, "HRWS", NULL, &temp);
> +	rv = acpi_evaluate_integer(asus->handle, "HWRS", NULL, &temp);
>  	if (!ACPI_FAILURE(rv))
> -		len += sprintf(page + len, "HRWS value         : %#x\n",
> +		len += sprintf(page + len, "HWRS value         : %#x\n",
>  			       (uint) temp);
>  	/*
>  	 * Another value for userspace: the ASYM method returns 0x02 for
> @@ -1751,9 +1751,9 @@ static int asus_laptop_get_info(struct asus_laptop *asus)
>  	 * The significance of others is yet to be found.
>  	 */
>  	status =
> -	    acpi_evaluate_integer(asus->handle, "HRWS", NULL, &hwrs_result);
> +	    acpi_evaluate_integer(asus->handle, "HWRS", NULL, &hwrs_result);
>  	if (!ACPI_FAILURE(status))
> -		pr_notice("  HRWS returned %x", (int)hwrs_result);
> +		pr_notice("  HWRS returned %x", (int)hwrs_result);
>  
>  	if (!acpi_check_handle(asus->handle, METHOD_WL_STATUS, NULL))
>  		asus->have_rsts = true;

Please also tag this commit

Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=24222

so we can track it back out of bugzilla.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ