linux-kernel - Re: [PATCH 09/20] staging: comedi: adv_pci1723: fix initial dio subdevice state and io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120820214916.GA11795@mwanda>
Date:	Mon, 20 Aug 2012 14:49:17 -0700
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	abbotti@....co.uk
Subject: Re: [PATCH 09/20] staging: comedi: adv_pci1723: fix initial dio
 subdevice state and io_bits

On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote:
> +	if (this_board->n_diochan) {
> +		s = dev->subdevices + subdev;

This pointer math sucks still...  I feel like the unreadable code is
part of what caused this bug.

We don't have to change these all at once.  If we fix only one line,
then at least one line will be readable and that is one more than
before so *improvement*.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/