linux-kernel - RE: [RFC][PATCH v2 1/3] efivars: Disable external interrupt while holding efivars->lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A5ED84D3BB3A384992CBB9C77DEDA4D413805F5B@USINDEM103.corp.hds.com>
Date:	Mon, 20 Aug 2012 22:08:35 +0000
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Mike Waychison <mikew@...gle.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Luck, Tony (tony.luck@...el.com)" <tony.luck@...el.com>,
	"Matthew Garrett (mjg@...hat.com)" <mjg@...hat.com>,
	"dzickus@...hat.com" <dzickus@...hat.com>,
	"dle-develop@...ts.sourceforge.net" 
	<dle-develop@...ts.sourceforge.net>,
	Satoru Moriya <satoru.moriya@....com>
Subject: RE: [RFC][PATCH v2 1/3] efivars: Disable external interrupt while
 holding efivars->lock



> -----Original Message-----
> From: Mike Waychison [mailto:mikew@...gle.com]
> Sent: Monday, August 20, 2012 3:17 PM
> To: Seiji Aguchi
> Cc: linux-kernel@...r.kernel.org; Luck, Tony (tony.luck@...el.com); Matthew Garrett (mjg@...hat.com); dzickus@...hat.com; dle-
> develop@...ts.sourceforge.net; Satoru Moriya
> Subject: Re: [RFC][PATCH v2 1/3] efivars: Disable external interrupt while holding efivars->lock
> 
> Acked-by: Mike Waychison <mikew@...gle.com>
> 
> > @@ -1101,11 +1107,12 @@ out_free:
> >  void unregister_efivars(struct efivars *efivars)  {
> >         struct efivar_entry *entry, *n;
> > +       unsigned long flags;
> >
> >         list_for_each_entry_safe(entry, n, &efivars->list, list) {
> > -               spin_lock(&efivars->lock);
> > +               spin_lock_irqsave(&efivars->lock, flags);
> >                 list_del(&entry->list);
> > -               spin_unlock(&efivars->lock);
> > +               spin_unlock_irqrestore(&efivars->lock, flags);
> >                 efivar_unregister(entry);
> >         }
> >         if (efivars->new_var)
> 
> Feel free to remove any other uses of flags where you know that you
> are being called from process context.

OK. I will remove the flags from unregister_efivars(), efivar_store_raw(), efivar_create() and efivar_delete().

If I'm missing something, please let me know.

Seiji


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/