linux-kernel - Re: [PATCH] perf: create a helper structure perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120821095920.GA3241@gmail.com>
Date:	Tue, 21 Aug 2012 11:59:20 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andrew Vagin <avagin@...nvz.org>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH] perf: create a helper structure perf_event_context


* Andrew Vagin <avagin@...nvz.org> wrote:

>  18 files changed, 222 insertions(+), 255 deletions(-)

> -static int process_sample_event(struct perf_tool *tool,
> -				union perf_event *event,
> -				struct perf_sample *sample,
> -				struct perf_evsel *evsel,
> -				struct machine *machine)
> +static int process_sample_event(struct perf_event_context *ectx)
>  {
> -	struct perf_annotate *ann = container_of(tool, struct perf_annotate, tool);
> +	struct perf_sample *sample = ectx->sample;
> +	struct perf_annotate *ann = container_of(ectx->tool, struct perf_annotate, tool);
>  	struct addr_location al;

that looks like a nice cleanliness win.

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/