linux-kernel - Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Aug 2012 15:21:09 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	manoj.iyer@...onical.com
CC:	linux-kernel@...r.kernel.org, sarah.a.sharp@...ux.intel.com,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

Hello.

On 21-08-2012 8:06, manoj.iyer@...onical.com wrote:

> From: Manoj Iyer <manoj.iyer@...onical.com>

> USB 3.0 devices show up as high-speed devices on powerup, after an
> s3 cycle they are correctly recognized as SuperSpeed. At powerup
> unconditionally switch the port to xHCI like we do when we resume
> from suspend.

> BugLink: http://bugs.launchpad.net/bugs/1000424

> Signed-off-by: Manoj Iyer <manoj.iyer@...onical.com>
> ---
>   drivers/usb/host/xhci-pci.c |    8 ++++++++
>   1 file changed, 8 insertions(+)

> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 9bfd4ca11..5c8dbea 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -48,6 +48,14 @@ static int xhci_pci_reinit(struct xhci_hcd *xhci, struct pci_dev *pdev)
>   	if (!pci_set_mwi(pdev))
>   		xhci_dbg(xhci, "MWI active\n");
>
> +	/*
> +	 * USB SuperSpeed ports are recognized as HighSpeed ports on powerup

    Devices, not ports?

> +	 * unconditionally switch the ports to xHCI like we do when resume

    s/resume/resuming/

> +	 * from suspend.
> +	 */
> +	if (usb_is_intel_switchable_xhci(pdev))
> +		usb_enable_xhci_ports(pdev);
> +

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/