linux-kernel - Re: [PATCH] tun: don't zeroize sock->file on detach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5033B199.6080305@parallels.com>
Date:	Tue, 21 Aug 2012 20:04:41 +0400
From:	Stanislav Kinsbursky <skinsbursky@...allels.com>
To:	David Miller <davem@...emloft.net>
CC:	"dhowells@...hat.com" <dhowells@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"rick.jones2@...com" <rick.jones2@...com>,
	"ycheng@...gle.com" <ycheng@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<mikulas@...ax.karlin.mff.cuni.cz>
Subject: Re: [PATCH] tun: don't zeroize sock->file on detach

10.08.2012 03:16, David Miller пишет:
> From: Stanislav Kinsbursky <skinsbursky@...allels.com>
> Date: Thu, 09 Aug 2012 16:50:40 +0400
>
>> This is a fix for bug, introduced in 3.4 kernel by commit
>> 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced
>> simple sock_put() by sk_release_kernel(). Below is sequence, which leads to
>> oops for non-persistent devices:
>>
>> tun_chr_close()
>> tun_detach()				<== tun->socket.file = NULL
>> tun_free_netdev()
>> sk_release_sock()
>> sock_release(sock->file == NULL)
>> iput(SOCK_INODE(sock))			<== dereference on NULL pointer
>>
>> This patch just removes zeroing of socket's file from __tun_detach().
>> sock_release() will do this.
>>
>> Cc: stable@...r.kernel.org
>> Reported-by: Ruan Zhijie <ruanzhijie@...mail.com>
>> Tested-by: Ruan Zhijie <ruanzhijie@...mail.com>
>> Acked-by: Al Viro <viro@...IV.linux.org.uk>
>> Acked-by: Eric Dumazet <edumazet@...gle.com>
>> Acked-by: Yuchung Cheng <ycheng@...gle.com>
>> Signed-off-by: Stanislav Kinsbursky <skinsbursky@...allels.com>
>
> Applied, thanks.
>

Hi, David.
I found out, that this commit: b09e786bd1dd66418b69348cb110f3a64764626a
was previous attempt to fix the problem.
I believe this commit have to be dropped.


-- 
Best regards,
Stanislav Kinsbursky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/