linux-kernel - Re: [PATCH] pstore: add missed platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+KvkQV94D+kT4b5+UcCX1wZz_04STb3H4CmB1Em-fB3g@mail.gmail.com>
Date:	Tue, 21 Aug 2012 09:19:15 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Jovi Zhang <bookjovi@...il.com>, tony.luck@...el.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Colin Cross <ccross@...roid.com>
Subject: Re: [PATCH] pstore: add missed platform_device_unregister

On Mon, Aug 20, 2012 at 6:40 PM, Anton Vorontsov <cbouatmailru@...il.com> wrote:
> On Mon, Aug 20, 2012 at 02:58:26PM +0800, Jovi Zhang wrote:
>> From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
>> From: Jovi Zhang <bookjovi@...il.com>
>> Date: Mon, 20 Aug 2012 14:20:01 +0800
>> Subject: [PATCH] pstore: add missed platform_device_unregister
>>
>> we need unregister platform device when module exit, add it.
>>
>> Signed-off-by: Jovi Zhang <bookjovi@...il.com>
>> ---
>>  fs/pstore/ram.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
>> index 0b311bc..adb218a 100644
>> --- a/fs/pstore/ram.c
>> +++ b/fs/pstore/ram.c
>> @@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
>>  static void __exit ramoops_exit(void)
>>  {
>>       platform_driver_unregister(&ramoops_driver);
>> +     platform_device_unregister(dummy);
>>       kfree(dummy_data);
>>  }
>>  module_exit(ramoops_exit);
>
> It looks OK to me. Unless there are objections I'll apply it to
> linux-pstore.git.

Yup, looks right.

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/