lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Aug 2012 09:29:18 -0700 From: tip-bot for Namhyung Kim <namhyung@...nel.org> To: linux-tip-commits@...r.kernel.org Cc: acme@...hat.com, linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org, peterz@...radead.org, penberg@...nel.org, namhyung@...nel.org, tglx@...utronix.de Subject: [tip:perf/core] perf ui gtk: Ensure not to call gtk_main_quit() twice Commit-ID: 2708bf3a30b7bfa02d60a3f03603b6b92d093f1a Gitweb: http://git.kernel.org/tip/2708bf3a30b7bfa02d60a3f03603b6b92d093f1a Author: Namhyung Kim <namhyung@...nel.org> AuthorDate: Sat, 18 Aug 2012 01:56:23 +0900 Committer: Arnaldo Carvalho de Melo <acme@...hat.com> CommitDate: Mon, 20 Aug 2012 09:29:12 -0300 perf ui gtk: Ensure not to call gtk_main_quit() twice Currently the gtk_main_quit() is called twice when perf exits so the following warning is emitted: [penberg@tux perf]$ ./perf report --gtk ^Cperf: Interrupt (perf:4048): Gtk-CRITICAL **: IA__gtk_main_quit: assertion `main_loops != NULL' failed Fix it by not to call it unnecessarily. Reported-by: Pekka Enberg <penberg@...nel.org> Signed-off-by: Namhyung Kim <namhyung@...nel.org> Acked-by: Pekka Enberg <penberg@...nel.org> Cc: Ingo Molnar <mingo@...nel.org> Cc: Pekka Enberg <penberg@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org> Link: http://lkml.kernel.org/r/1345222583-3964-1-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com> --- tools/perf/ui/gtk/setup.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/perf/ui/gtk/setup.c b/tools/perf/ui/gtk/setup.c index ad40b36..ec1ee26 100644 --- a/tools/perf/ui/gtk/setup.c +++ b/tools/perf/ui/gtk/setup.c @@ -13,6 +13,8 @@ int perf_gtk__init(void) void perf_gtk__exit(bool wait_for_ok __used) { + if (!perf_gtk__is_active_context(pgctx)) + return; perf_error__unregister(&perf_gtk_eops); gtk_main_quit(); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists